Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name and protocol to discovery info packet. #535

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Add name and protocol to discovery info packet. #535

merged 1 commit into from
Mar 23, 2016

Conversation

philwinder
Copy link
Contributor

Fixed #480. Will now produced discovery info packets that look like:

discovery {
  visibility: EXTERNAL
  name: "--executorName"
  ports {
    ports {
      number: 9200
      name: "CLIENT_PORT"
      protocol: "TCP"
    }
    ports {
      number: 9300
      name: "TRANSPORT_PORT"
      protocol: "TCP"
    }
  }
}

Where "--executorName" is the value passed into the framework with the --executorName setting.

@philwinder
Copy link
Contributor Author

Jenkins pass: https://ci.infra.container-solutions.com/job/ElasticsearchPullRequests/304/console

@philwinder philwinder merged commit 096a8eb into master Mar 23, 2016
@philwinder philwinder deleted the enhancement/480-DiscoveryInfo branch March 23, 2016 10:33
@tpolekhin
Copy link

Shouldn't that be protocol: "HTTP"?

    ports {
      number: 9200
      name: "CLIENT_PORT"
      protocol: "TCP"
    }

@philwinder
Copy link
Contributor Author

philwinder commented Apr 21, 2016 •
edited
Loading

Yes, you're right.

#558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philwinder @tpolekhin